🧪 [Add comprehensive tests for ollama New function]#82
Conversation
Addresses the testing gap in Ollama plugin's `New` constructor. The default initialization logic and auto-probing of the `/api/version` endpoint for OpenAI Responses API compatibility now has explicit coverage. Added test coverage for: - Probing `/api/version` with HTTP mocks and detecting `0.1.0` vs `>=0.13.3`. - Emitting `lipapi.OperationOpenAIResponses` support correctly in `ResolveTransportCaps` depending on the version. - Disallowing explicitly `openairesponses.model` in `be.Open` on older Ollama versions, emitting errors appropriately. - The explicit configuration to force enable or disable `ResponsesAPI`. Co-authored-by: matdev83 <211248003+matdev83@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use the repo's _, _ = w.Write(...) idiom for httptest handlers to satisfy errcheck. Co-authored-by: Cursor <cursoragent@cursor.com>
1 participant
Newconstructor has been addressed. The default initialization logic and auto-probing of the/api/versionendpoint for OpenAI Responses API compatibility lacked tests./api/versionwith HTTP mocks and detecting0.1.0vs>=0.13.3.lipapi.OperationOpenAIResponsessupport correctly inResolveTransportCapsdepending on the version.openairesponses.modelinbe.Openon older Ollama versions, emitting errors appropriately.ResponsesAPI.PR created automatically by Jules for task 3464184568522072264 started by @matdev83